Download logs #222
Merged
Download logs #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
force-pushed
the
download-logs
branch
from
1ef3420 to
3c29a2a
Compare
ThetaSinner
commented
Jul 17, 2024
| /// Messages returned directly by the TryCp server, rather than relayed from Holochain | ||
| #[derive(Debug, serde::Deserialize, serde::Serialize)] | ||
| #[serde(rename_all = "snake_case", tag = "type", content = "data")] | ||
| pub enum TryCpServerResponse { |
There was a problem hiding this comment.
Some type f*ry required to let the JS client decode these types. It's the first time we've returned anything more complicated than a string and the JS client has a special case for strings.
neonphog
reviewed
Jul 17, 2024
| std::fs::read(&conductor_stdout).context(HolochainStdout { id: id.clone() })?; | ||
|
|
||
| let conductor_stderr = player_dir.join(CONDUCTOR_STDERR_LOG_FILENAME); | ||
| let conductor_stderr = std::fs::read(&conductor_stderr).context(HolochainStderr { id })?; |
There was a problem hiding this comment.
are we cool with these blocking whatever thread happens to be running?
There was a problem hiding this comment.
The entire function is being run on a blocking thread -> https://github.com/holochain/tryorama/pull/222/files#diff-db8eb8bbb5e02b33e796b281bce321e0d781f68204bac8f217e5eddbe9e34319R256
This seems to be the established pattern for the trycp_server, to offload the entire function if it's not async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.